Repository navigation
Restore CI knowledge capacity with test fixture topic - #134
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2539620763
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| baseline artifact；没有实际 lane 结果或显式 consumer 时，不得把 PR 预期或 JSON baseline | ||
| 说成性能不变或 regression-gate verdict。^[PR #6613] | ||
|
|
||
| ## OMNI-CI-2d — diffusion tiny builder 必须替代资源缩减而不是能力缩减 |
There was a problem hiding this comment.
Moving this heading leaves knowledge/repos/vllm-omni/models/flux/_index.md:43 pointing to the now-missing rules.md#omni-ci-2d-... fragment; a repo-wide rg found this remaining reference, so readers following the Flux acceptance-gate link no longer reach the rule. Update that link to the corresponding anchor in rules-test-fixtures.md.
AGENTS.md reference: AGENTS.md:L7-L11
Useful? React with 👍 / 👎.
Automatic knowledge batches could only append to each owner's rules.md entry page, and several of those pages sit within a few hundred bytes of the tree validator's 32 KiB split gate. Every rule routed there failed validation after apply, rolled the whole batch back, and needed a human to split the page by hand (#133, #134). The catalog now lists every owner rule page: the rules.md entry page and the owner's type: rule rules-<topic>.md topic pages the tree already uses. catalog_entries() carries each page's remaining bytes and non-empty lines, mirrored from check_knowledge_tree.py, the prompt shows that room, and validate_proposals rejects a proposal that would not fit ("page full") before anything is written, consuming room across one batch so two rules aimed at one page cannot both pass. Knowledge API 1.0.0 -> 1.1.0, backward compatible. The knowledge contract sentence that named rules.md as the only PR learning target now names the owner's rule pages; SPEC/sdk.md and SPEC/contract.md record the new surface and version. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Js5CsiwSYjcAYvqti1Lp1Y
The live automatic intake repair fixed the other page-size errors, but CI rules remained at 34,442 bytes. Move the existing parallel test infrastructure, reusable engine fixture, and diffusion tiny-builder rules verbatim into an owner-local topic page. Link the topic from the CI rule entry page and index, restoring entry-page capacity without weakening validators or removing rule content.
Validation: both knowledge validators and the enforced release-baseline audit pass; git diff --check passes.