Repository navigation
knowledge: daily intake batch 08 (recovered and curated) - #145
Merged
Merged
Conversation
The bot distilled rows 50-69 (20 merged vllm-omni PRs) into 19 rules on 2026-09-08/09 but could never publish them: three hourly push failures (publish token not yet deployed) parked the rows and the branch was left orphaned in the host work clone (see omni-reviewbot#53). This lands that content, curated by hand the same way as the 09-09 batch: - IDs that already headed sections elsewhere renamed so every ID heads exactly one section tree-wide: OMNI-CI-3e -> OMNI-CI-3g, OMNI-CI-1e -> OMNI-CI-1f, DIFF-1o -> DIFF-1ah, DIFF-2ab -> DIFF-2af. - Every cited PR added to its page's `sources:` frontmatter. - Routing: Direct/review-group table rows for all 19 rules on the owner entry pages, and the nearest `_index.md` rows extended. - rules-system-runtime.md appends DIFF-4aa/4ab after the 09-09 batch's DIFF-4ac (stacked on knowledge/intake-2026-09-09). - MMH3-2j reconciled with the new MMH3-2p: its exact-artifact clauses (single v1.0 filename, alpha 128, fixed 4-step/shift-6 schedule, Ref2VA rejected outright) now defer to the artifact-derived TurboSpec that MMH3-2p defines, while its lifecycle, packing and DLO requirements stay in force. Validators: check_knowledge_tree 0 errors, check_wiki_lint 0 errors, test_knowledge_source green. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MAFmwP3u5qAMDgHfM6LFi
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The extra Direct-table row for VOMNI-CFG-1s pushed the configuration owner's quick map past the size Direct can deliver inline, so every review routed there paid a file read (test_direct_routes_title_body_before_changed_files: knowledge_file_reads 3 != 2). Fold the ID into the existing `strict-normalization` cell instead; the rule itself is unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MAFmwP3u5qAMDgHfM6LFi
tzhouam
added a commit
that referenced
this pull request
Sep 10, 2026
The batch was distilled on the SDK pinned before #142 and against a main that predates #140/#145, so it reused two IDs those batches landed and its audit ran against the retired baseline. Merge main in and curate: - VOMNI-CFG-1s (CLI-only negative alias) -> VOMNI-CFG-1t and MCPMO-2e (audio_embeds registration) -> MCPMO-2f: both IDs already head other rules on main; every ID now heads exactly one section tree-wide. - The configuration entry page crossed the 32 KiB split cap once main's VOMNI-CFG-1s and this batch's 1t both sat on it. Both engine-args rules move to the existing topic page rules-legacy-engine-args.md (the owner's engine-args topic), the entry page's Direct table links there, and the nearest _index.md row is extended. No inbound anchors referenced them. - Every cited PR added to its page's `sources:` frontmatter; Direct table rows for OMNI-CI-2g/2h, DIFF-1af, MCPMO-2f, VOMNI-CFG-1t and _index.md rows for benchmark, ci, configuration and diffusion. The review gate also noted that the SDK deduplicates heading IDs within a single section, so a section repeating its own ID in a nested heading is not rejected; that is an SDK change and ships separately. Validators: check_knowledge_tree 0 errors, check_wiki_lint 0 errors, test_thin_mcp_server and test_knowledge_source green. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MAFmwP3u5qAMDgHfM6LFi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily knowledge-intake batch for 2026-09-08 (intake rows 50-69, 20 merged vllm-omni PRs), recovered by hand. The bot committed these 19 rules on 2026-09-08/09 but could never publish them: three hourly push failures (the publish token from omni-reviewbot#51 was not deployed yet) parked the rows and left the branch orphaned in the host work clone. omni-reviewbot#53 fixes that failure mode; this PR lands the content. Merging this PR is the human promotion gate.
Stacked on #140 (base
knowledge/intake-2026-09-09): both batches append torules-system-runtime.md. Merge #140 first; GitHub retargets this PR tomain.Curation applied on top of the bot's commits
OMNI-CI-3e→OMNI-CI-3g,OMNI-CI-1e→OMNI-CI-1f,DIFF-1o→DIFF-1ah,DIFF-2ab→DIFF-2af(root cause fixed in sdk(knowledge): reject rule IDs that already head a section on any catalog page #142).sources:frontmatter._index.mdrows extended.Rules
OMNI-CI-3gtask↔checkpoint pairing;OMNI-CI-3fspeaker-embedding miss-EOS retryOMNI-CI-1fscheduled CUDA mirror secret env aliasVOMNI-CFG-1sglobal stage engine args owner check,diffusion_offload_configDIFF-1ahequal-rank SP auto-pad fast pathDIFF-2afDiffusers.binTorchAO index fallbackDIFF-1agmid-stream interaction handlerDIFF-4aaAR-Diffusion K/V separate storage;DIFF-4abstepwise single-request rolloutDIST-1kMooncake TCP write completionEXEC-4fone-token prefill tail keeps preprocessBOOGU-1eTurbo DMD path;BOOGU-1fTorchAO FP8 DiT-onlyHY3-9aget_expert_mappingflat listMCPMO-4ifull-attention Talker rolloverMMH3-2oalias metadata parity;MMH3-2pTurbo filename contractMMH3-2qtext_conditioning/v1schema fail-closedQWENIMG-1cEdittxt_seq_lensfrom padded widthSource events (rows 50-69)
PR #5929, #7111, #6699, #7118, #7054, #6925, #6924, #5717, #7062, #6720, #7021, #6799, #7136, #7162, #6294, #6463, #5586, #6844, #7189, #7178 (doc-only PRs #7111/#7189/#7178 produced no rule).
Validators
check_knowledge_tree 0 errors · check_wiki_lint 0 errors · test_knowledge_source green.
Ledger follow-up
After merge, rows 50-69 on the bot host are marked
distilledwith this PR asbatch_ref(instead of being requeued), and the orphaned host branch is deleted.🤖 Generated with Claude Code
https://claude.ai/code/session_018MAFmwP3u5qAMDgHfM6LFi