Repository navigation
knowledge(vllm-omni): 1 change(s) from rebuild - #424
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abb23f3369
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## VLLM-OMNI-PR9406-ASYNC-POLL-SLEEP — stage memory 生命周期测试的 _wait_until 轮询禁止 sleep(0) 忙等 | ||
|
|
||
| - 触发：改动 `tests/engine/test_stage_memory_lifecycle.py` 中 `_wait_until` 轮询助手——`while not predicate()` 循环内的休眠间隔或外层 `asyncio.wait_for` 的超时取值。 |
There was a problem hiding this comment.
This rule exclusively targets tests/engine/test_stage_memory_lifecycle.py and replica-registration lifecycle behavior, but it is stored under Distributed. The existing ownership map explicitly assigns stage lifecycles to Serving (components/distributed/_index.md, “不放什么”), and components/serving/rules.md routes membership registration and stage-pool lifecycle work to rules-engine-lifecycle.md. Consequently, owner-scoped reviews of the affected lifecycle code will not encounter this safeguard. Move the rule to the Serving lifecycle rules and update that owner's index, as required by the root AGENTS.md nearest-owner policy.
AGENTS.md reference: AGENTS.md:L12-L14
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-rebuild-31edd9fee557).repos/vllm-omni/components/distributed/rules.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.