Repository navigation
knowledge(vllm-omni): 1 change(s) from refine - #425
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a95c0b54f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## VLLM-OMNI-PR9391-DRAMA3-INT4 — Drama 3 hybrid INT4 量化必须解析期拒绝不支持形态，fused 层先展开 shard 再按 dense.targets 后缀分发 | ||
|
|
||
| - 触发：`vllm_omni/model_executor/models/fish_omni/quantization.py` 新增或修改模型专属量化注册（如 `drama3-int4` hybrid GPTQ）、experts/dense 分节量化或 per-prefix 量化分发，或改动与其共存的 NPU `bsgemm-moe`（`ExpertFp8Config`）路径；该 INT4 checkpoint 的文档口径是 CUDA SM80+（Ampere 及更新，A100 已验证）。 |
There was a problem hiding this comment.
This rule exclusively governs models/fish_omni/quantization.py, a model-specific checkpoint format, and its model-specific tests, but places the entire body under the shared model-executor component. Root AGENTS.md explicitly requires model-specific rules to stay with their model owner, and the component index itself excludes model-specific checkpoint logic. This also bypasses Direct's model discovery, which enumerates models/*/rules.md, leaving no Drama 3 model rule entry for model-name routing. Put the rule under the corresponding model owner, update that owner's index, and retain only a routing link in the shared component if needed.
AGENTS.md reference: AGENTS.md:L12-L14
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-refine-262873a6535b).repos/vllm-omni/components/model-executor/rules-drama3-quant.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.