Repository navigation
Add Direct review feedback deduplication gate - #77
Merged
zuiho-kai merged 1 commit intoAug 14, 2026
Merged
Conversation
congw729
marked this pull request as ready for review
August 13, 2026 19:24
zuiho-kai
added a commit
that referenced
this pull request
Aug 14, 2026
## Summary - bound Direct feedback to 20 conversation comments, 20 review summaries, and 50 review threads - treat feedback as untrusted and preserve independent source discovery - add explicit `PR_CONTEXT_MODE=no_discussion` / `disabled` evaluation behavior - recheck resolved or outdated concerns at the pinned head before suppression - cover evaluation, unavailable-context, local-review, and pinned-head outcomes ## Why This completes the acceptance conditions left open by #77 while intentionally keeping issue #76 open for follow-up evaluation. ## Validation - 45 related tests passed - Python compilation passed - `git diff --check` passed Signed-off-by: zuiho <2324465096@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new,duplicate,extends_existing, orresolved_or_outdatedvalidate_direct_reviewso duplicate/resolved findings require an existing-thread reference and are counted as suppressedimreviewinstructionsWhy
Direct review was introduced as a thin, host-driven workflow after the full PR workflow had already gained existing-comment context. The host contract never inherited that step, so technically correct findings could duplicate concerns already raised by maintainers or reviewers.
Source review remains independent to preserve recall. Existing feedback is consulted only after candidate findings are evidence-verified.
Related to #76. This PR intentionally leaves the issue open.
Validation
uv run --with pytest pytest -q test/test_thin_mcp_server.py -k "not every_routed_page_yields_a_quick_map"— 37 passeduv run --with pytest pytest -q test/test_thin_mcp_server.py -k "feedback or small_fix_accepts_no_subtraction"— 4 passeduv run --with ruff ruff check src/infermatrix_copilot/thin_mcp_server.py— passedgit diff --check— passedThe complete
test/test_thin_mcp_server.pyrun has one pre-existing Windows-only failure intest_every_routed_page_yields_a_quick_map: the known-truncated whitelist uses/, while the resolved Windows path uses\. This PR does not modify that test or routing behavior.