Skip to content

fix: recognize exact status-capacity messages in string responses - #206

Merged
Dong1017 merged 3 commits into
mainfrom
fix/admission-capacity-response-format
Oct 28, 2026
Merged

Dong1017 merged 3 commits into
mainfrom
fix/admission-capacity-response-format

Conversation

@Dong1017

Copy link
Copy Markdown
Collaborator

Refs #203. Narrow response-format compatibility follow-up to #205.

Live run 40628967145 proves the five unknown 422 responses are parsed JSON objects with errors as a string, not the array the existing classifier expected. This PR recognizes only the existing fixed, full status-capacity message in that string position. Arbitrary/near-miss text remains unknown; no raw content is logged, and capacity remains an execution failure rather than compliance.

flowchart LR
 A[Observed errors string] --> B[Exact known-message match only]
 B --> C[Capacity failure or still unknown]
Loading

Base 70adb9f0a963756d040100a25cc708787efa249e; head 056b2883902c93344173b8e31dae1fb7a5198f7c. Implementation reviewed against prior 2c1da9dc; intervening #194 coverage-view files are disjoint from all three modified paths.

Checks: 187 focused tests / 79 subtests passed, Ruff and whitespace passed. Independent read-only review LGTM and 19 HTTP tests passed. Hosted CI pending. No live POST experiment/dispatch, threshold change or invented capacity diagnosis.

The string's actual match is still to be observed after merge. #203 remains open; this does not restore remote status capacity or clear historical red checks.

Signed-off-by: X. DONG <xwdong1998@gmail.com>
Agent-assisted-by: OpenAI Codex
Signed-off-by: X. DONG <xwdong1998@gmail.com>
Agent-assisted-by: OpenAI Codex
Signed-off-by: X. DONG <xwdong1998@gmail.com>
Agent-assisted-by: OpenAI Codex
@Dong1017
Dong1017 marked this pull request as ready for review October 28, 2026 03:57
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-28T03:57:55.990120Z 056b288 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Dong1017 Dong1017 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent delegated review: LGTM for this narrow compatibility patch at 056b2883902c93344173b8e31dae1fb7a5198f7c, base 70adb9f0a963756d040100a25cc708787efa249e. The reviewer inspected the exact three-file patch without edits and independently passed 19 HTTP tests. Only the existing full fixed capacity message is recognized in the newly observed errors string format; near-miss/arbitrary strings remain unknown and raw text stays private. Capacity remains an execution failure, never compliance.

Ready 40629617190: all four jobs passed. Current canonical admission success. Focused suite 187 passed/79 subtests; Ruff and remote/local file equivalence passed.

flowchart LR
 A[Observed string error format] --> B[Exact allowlisted match]
 B --> C[Capacity failure or unknown]
 C --> D[Live classification still to verify]
Loading

No live message match or restoration of old status capacity is claimed yet; #203 remains open.

@Dong1017
Dong1017 merged commit 5bea157 into main Oct 28, 2026
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant