Repository navigation
fix: accept the model identifier the dashboard shows - #384
Merged
Merged
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy form writes the deployment's name into
model_name, and the lookup matchedmodel_nameandllmd_resource_nameonly.inference_modelholds the model id and is what the dashboard renders in its Model column, so the one identifier a user could see was the one that returned 401.The miss also reported one message for two unrelated failures. A key bound to a deployment that no longer exists now says that; an org-scoped miss names the model and type it looked for.
One known limitation: matching
inference_modelmakes the lookup ambiguous when two deployments in an org run the same model. The query takes the first row, so it picks arbitrarily. That was already possible viamodel_name, but this makes it likely rather than theoretical.closes #382