Skip to content

chore: new release processes - #1092

Open
joaodordio wants to merge 6 commits into
masterfrom
chore/new-release-processes
Open

joaodordio wants to merge 6 commits into
masterfrom
chore/new-release-processes

Conversation

@joaodordio

@joaodordio joaodordio commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Summary

Replaces the existing ad-hoc release workflows with a standardized two-step process across all SDKs.

No customer facing changes

Workflow 1: Prepare Release (workflow_dispatch)

Inputs: version, ticket

  • Updates CHANGELOG.md (promotes [Unreleased] to new version section)
  • Bumps all version files
  • Opens a release PR with a checklist
  • Creates a GitHub draft release (no tag created yet, nothing published)

Workflow 2: Publish Release (workflow_dispatch)

Input: version

  • Verifies the prepare-release PR has been merged (checks CHANGELOG on master)
  • Publishes the draft release and creates the tag on master at this moment
  • Publishes to the SDK's distribution platform
  • Posts to #eng-sdk-team on Slack

Files changed

  • Added .github/workflows/prepare-release.yml
  • Added .github/workflows/publish-release.yml
  • Deleted old release workflow(s)

Configuration required before first run

GitHub App (Prepare and Publish)

  • Repository variable: ITERABLE_SDK_RELEASE_APP_ID — App ID for the iterable-sdk-release GitHub App
  • Repository secret: ITERABLE_SDK_RELEASE_APP_PRIVATE_KEY — PEM private key for the App

Install the App on this repository with permissions to create PRs, manage releases, and write contents.

Publish Release only

  • SLACK_WEBHOOK — webhook URL for #eng-sdk-team notifications
  • COCOAPODS_TRUNK_TOKEN — CocoaPods trunk token for pod_trunk_push

Related: [SDK Release Process Team Agreement 2026-09-11]

No customer facing changes

Replaces the monolithic release workflow with a two-step process:
- Prepare Release: bumps version, updates changelog, opens PR, creates GitHub draft release
- Publish Release: promotes draft, tags master/main, publishes to distribution, posts Slack

Ref: SDK release process team agreement 2026-09-11
@joaodordio
joaodordio requested a review from a team as a code owner September 11, 2026 18:04
@codecov

codecov Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.65%. Comparing base (d97e76e) to head (1834cb7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1092      +/-   ##
==========================================
- Coverage   73.67%   73.65%   -0.02%     
==========================================
  Files         114      114              
  Lines       10202    10202              
==========================================
- Hits         7516     7514       -2     
- Misses       2686     2688       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jferrao-itrbl

Copy link
Copy Markdown

This PR does not touch CHANGELOG.md. The body does not contain No customer facing changes as per .github/workflows/changelog-check.yml ~41 -> 53.

The rule says that CHANGELOG update fails unless the diff includes CHANGELOG.md or the body contains that exact opt-out (rules/reviewer.md Tooling and process; PR template Changelog section).

Why it conflicts
Required check will fail; this PR is process-only and should opt out, not claim a product changelog line.

Suggested action
Add No customer facing changes to the PR body (or a changelog line if you consider this customer-visible).

Comment thread .github/workflows/publish-release.yml Resolved
Comment thread .github/workflows/prepare-release.yml Resolved
… grep

- Add ref: master/main to actions/checkout in all prepare/publish workflows
  so workflows always operate on the default branch regardless of dispatch ref
- Replace shell-injection-prone ${{ steps...outputs.notes }} pattern with
  --notes-file using $RUNNER_TEMP/release-notes.md (safe from backticks/quotes
  in changelog content)
- Treat empty [Unreleased] section as a hard error in prepare-release
- Fix CHANGELOG verification grep: grep -qE "^## \[VERSION\]" (anchored,
  prevents substring matches and prefix collisions like 3.1.0 vs 3.1.0-rc1)
Replace SDK_RELEASE_TOKEN (iOS) and GITHUB_TOKEN (all repos) with a
short-lived installation token from the iterable-sdk-release GitHub App,
generated via actions/create-github-app-token@v1.

Benefits:
- App token triggers CI on PRs it creates (GITHUB_TOKEN cannot)
- 1h TTL vs long-lived PAT
- Workflow-scoped permissions so we can push .github/workflows/ files

Required credentials (repo variable + secret, or set at org level):
  vars.ITERABLE_SDK_RELEASE_APP_ID
  secrets.ITERABLE_SDK_RELEASE_APP_PRIVATE_KEY
@jferrao-itrbl

Copy link
Copy Markdown

PR description “Secrets to add” is stale after 2ee8b46

What the code does: Workflows now require vars.ITERABLE_SDK_RELEASE_APP_ID and secrets.ITERABLE_SDK_RELEASE_APP_PRIVATE_KEY. The body still only mentions SLACK_WEBHOOK.

What the spec says: Call out secrets that must exist before the first run.

Why it conflicts: A reader following the PR body will miss the App install/credentials, and the first Prepare/Publish will fail at token minting.

Suggested action: Update the PR body (and keep SLACK_WEBHOOK) to match the App-token commit.

exit 1
fi

- uses: ruby/setup-ruby@v1
Require dispatch from master, verify draft release state and absent
version tag before publish, and reject whitespace-only Unreleased notes.
@jferrao-itrbl
jferrao-itrbl force-pushed the chore/new-release-processes branch from 4ff82f3 to a756b44 Compare October 6, 2026 12:17
Add docs_pr input so generated release PRs pass Validate Release PR,
pin create-github-app-token, make publish resumable with --clobber and
remote tag checks, and handle prereleases without --latest.
@jferrao-itrbl
jferrao-itrbl self-requested a review October 6, 2026 13:26
On resume, check out refs/tags/<version> and skip xcframework build and
upload so assets stay tied to the tagged commit. Set --latest=false when
publishing prerelease drafts.
Comment thread .github/workflows/prepare-release.yml Resolved
Comment thread .github/workflows/prepare-release.yml Resolved
Comment thread .github/workflows/publish-release.yml Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants