Repository navigation
fix(entrypoint): honor PGPORT in initialization SQL - #36
Open
youngkermit8-coder wants to merge 1 commit into
Open
youngkermit8-coder wants to merge 1 commit into
youngkermit8-coder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
PGPORT=6543starts the temporary server on 6543, but initialization SQL still connects to the hard-coded port 5866. Use the same${PGPORT:-5866}fallback for the SQL client and server so database creation and init scripts can connect. Update the root entrypoint and all ten generated version/variant copies.Validation:
bash tests/entrypoint-port.sh: 22 default/custom-port cases across all 11 entrypoints, with database commands stubbed. The custom-port case fails on the base revision and passes with this change.git diff --checkpasses. No live database server or full image build was run.