Repository navigation
fix(entrypoint): quote configuration paths under PGDATA - #37
Open
youngkermit8-coder wants to merge 1 commit into
Open
youngkermit8-coder wants to merge 1 commit into
youngkermit8-coder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
PGDATApath such as/tmp/data with spacesis split into multiple filenames by the post-initdbsedcommands, aborting initialization. Quote both configuration paths and synchronize all generated entrypoints. The optionalivorysql.confguard is preserved.Validation:
bash tests/entrypoint-pgdata.sh: 66 cases across 11 entrypoints, exercising plain, space-containing and bracket-containing paths, both with and withoutivorysql.conf. This runs the realsededits with initdb stubbed; the space-containing baseline fails and the patched cases pass.git diff --checkpasses. No live database server or full image build was run.