Repository navigation
fix(helm): derive Patroni discovery labels from chart values - #39
Open
youngkermit8-coder wants to merge 1 commit into
Open
youngkermit8-coder wants to merge 1 commit into
youngkermit8-coder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing
applicationNameorclusterNameupdates the Pod and Service labels, butPATRONI_KUBERNETES_LABELSstill selects the default cluster. Render the discovery labels from the same values as the workload, serialized as quoted JSON, so Patroni and the Kubernetes objects agree.Validation:
python tests/test_helm_labels.pywith Helm 3.19.0 and PyYAML verifies default and custom cluster/application names against Pod labels, Patroni scope and Service selectors. Custom names fail on the base revision and pass with the fix.git diff --checkpasses. These are render-time regression tests; no live Kubernetes cluster deployment was run.