Repository navigation
fix(helm): apply configured image pull secrets to Pods - #40
Open
youngkermit8-coder wants to merge 1 commit into
Open
youngkermit8-coder wants to merge 1 commit into
youngkermit8-coder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imagePullSecretsis exposed in values.yaml but never rendered into the StatefulSet Pod spec. Private registry users therefore cannot pass their pull credentials through the chart. Render the configured list at Pod scope, omitting the field when the list is empty.Validation:
python tests/test_helm_pull_secrets.pywith Helm 3.19.0 and PyYAML verifies the default omission and exact propagation of two named secrets. The custom case fails on the base revision and passes with this change. No secret contents are included or needed.git diff --checkpasses. These are render-time regression tests; no live Kubernetes cluster deployment was run.