Repository navigation
The tracker no longer checks that a path is a string - #100
Merged
Merged
Conversation
isWatched, setWatched, covers and setPosition each tested typeof path === 'string', but every caller passes a string: the detail rows only with a set entry.path, playback only after _following() checked player.path, which pathOf() makes a string or null. Fixes #97 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracker.isWatched,setWatched,coversandsetPositiondropped theirtypeof path === 'string'checks (simplicity.md: no checks for values that cannot be anything else). Every caller already passes a string:detailView.jsonly with a truthyentry.pathfrom the scanner'slibrary.json,playback.jsonly after_following()checkedplayer.path, whichpathOf()makes a string or null. Theenabledchecks stay; thetypeofchecks on parsed JSON entries stay (outside data).Fixes #97
Verified
make checkstart --stand-in): a show's detail lists its episodes, the watched disc on a stand-in episode marks it (written to the stand-inwatched.json) and the tick reads back on reopening; no errors in the logstop+start: not an enable-path change.claude/rules/, skills anddocs/still true🤖 Generated with Claude Code