Repository navigation
Optional calls on methods Shell 50 has are plain calls - #106
Merged
Merged
Conversation
dash._hookUpLabel, _dashContainer and Dash to Panel's updateElementPositions run inside _attach()'s try/catch, so a moved member now logs a warning rather than failing silently. _queueCheckWorkspaces and setPrimaryWorkspaceVisible are called directly, and tracking.js and playback.js share one isCancelled(). private-api.md and publishing.md's review section follow. Fixes #105 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From an extensions.gnome.org review pass against gjs.guide's review guidelines and best practices (read 2026-10-08, unchanged since 2026-10-02):
?.()on methods GNOME Shell 50 has is an unnecessary check a reviewer flags, and on a private method it fails silently.dash._hookUpLabel,_dashContainerand Dash to Panel'supdateElementPositionsnow run plainly inside_attach()'s existing try/catch (a moved member logs a warning);_queueCheckWorkspacesandsetPrimaryWorkspaceVisibleare called directly;tracking.jsandplayback.jsshare oneisCancelled(). The 56tryblocks were each read and kept: all guard I/O, a subprocess, an async finish, outside data or a private/Dash to Panel reach.Fixes #105
Verified
make check(ESLint clean, schema, scanner);make packships exactly the 33 filesui/dash.js,ui/windowManager.jsandui/workspacesView.js(extracted from libshell's gresource).claude/rules/, skills anddocs/still true:docs/private-api.md's Guarded column anddocs/publishing.md's review section updated🤖 Generated with Claude Code