Repository navigation
disable() stops the scanner it started - #98
Merged
Merged
Conversation
lib/app.js only cancelled the Gio.Cancellable passed to communicate_utf8_async, which drops the wait for the scanner's output but leaves the gjs process running past a disable or a screen lock. disable() now force_exit()s the Gio.Subprocess, and a scan that is no longer the app's own is ignored when its output lands. Fixes #95 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disable()only cancelled the cancellable given tocommunicate_utf8_async, which abandons the wait for the scanner's output but leaves thegjs -m backend/scanLibrary.jsprocess running. It now keeps theGio.Subprocessand callsforce_exit()on it; the completion callback ignores a process that is no longer the app's own, so a stopped scan neither logs a failure nor schedules a rebuild after disable.Fixes #95
Verified
make checkstart --stand-in, Games emptied,games-steam-pathpointed at a stand-in Steam folder whoselibraryfolders.vdfis a FIFO, so the scan blocks): before, Find Games thennested.sh reloadleft thegjs … scanLibrary.js --only gamesprocess running, reparented; after, the same reload ends it, and nothing is logged for it. A scan that is allowed to finish still rebuilds the section ([Library Menu] Rebuilt) and restores Find Games.stop+start: enabled cleanly, no errors in the log.claude/rules/, skills anddocs/still true (the scanner's lock is a bus name, released however the process ends)🤖 Generated with Claude Code