Repository navigation
Import reads only the key file the user picks - #99
Merged
Merged
Conversation
Each key row's Import button read ~/Documents/keys/<SERVICE>/<file> straight away, and the row probed for that file to decide whether to show the button, so the preferences read a file the user never chose. Import now opens a Gtk.FileDialog, on the key drop's file when there is one, and reads the picked file asynchronously. Fixes #96 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each API key row's Import button read
~/Documents/keys/<SERVICE>/<file>directly, with no choice by the user (and the row stat'ed that file to decide whether to show the button). Import is now always shown and opens aGtk.FileDialog(title "Import the "), starting on the key drop's file for that field when it exists, otherwise in Documents; only the picked file is read, withload_contents_async, trimmed, and saved into the slot as before. Cancel reads nothing. CLAUDE.md's credentials paragraph says so.Fixes #96
Verified
make checkstart --stand-in, a made-upDocuments/keys/TMDB/API KEY.txtin the stand-in home, nested settings only): before, Films → TMDB → Import settmdb@1at once with no dialog; after, Import opens the file dialog inDocuments/keys/TMDBwith the credentials still empty; Escape leaves them empty; picking the file and Open setstmdb@1to the file's contents, and Check becomes sensitive.stop+start: not needed, preferences only (no enable path).claude/rules/, skills anddocs/still true🤖 Generated with Claude Code