Conversation
Reconciles the two branches that both wrote mixing, and adopts the GeneratorName to ChannelName rename across the player's own files. The mixing conflict resolves to mix/align/common_length: mix_audios returned float32 for one recording and float64 for two, while load_audio documents float32 throughout. mix_audios and _sum_approximations were the same rule written twice, and mix is their union, so both go and the three call sites read from one unit. The rename changes what GeneratorName means rather than retiring it, and both enums are StrEnum, so their TRIANGLE and NOISE members compare and hash equal across the two. An unrenamed file therefore half-works. mypy is what sees the difference, and it is clean over the merged tree.
The file-dialog factory and the zimtohrli referee probed for their programs with shutil.which, which the player's toolchain already answers through locate_program. One mechanism now answers "is this program installed" everywhere, and each probe reads back a Path. Both are availability probes rather than failures, so they take locate_program alone; missing_program_message stays with cc65 and ffmpeg, the tools that must name an install hint. scripts/detect_cuda.py keeps its own shutil.which: it selects the CUDA extra before the packages are installed, so it imports none of them.
…erators and the exporters
…ned by the arpeggio beside them
Basic Shapes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.