Repository navigation
patches/0004: match JavaIoFileSystem error contract in WindowsFileSys… - #14
Merged
Merged
Conversation
…tem#readdir Files.walkFileTree throws java.nio.file.NoSuchFileException when the path is missing, but RemoteActionFileSystem.getDirectoryContents only catches java.io.FileNotFoundException — the NIO exception slipped past and broke validation of disk-cache-restored tree artifacts in BwoB mode (e.g. "error while validating output tree artifact ...: \.../META-INF"). Translate NIO exceptions inside readdir to match the base JavaIoFileSystem.getDirectoryEntries contract: - NoSuchFileException -> FileNotFoundException(path + " (No such file or directory)") - NotDirectoryException -> IOException(path + " (Not a directory)") Also guard the visitor: walkFileTree(maxDepth=1) calls visitFile on the start path when it isn't a directory, so detect that and surface a NotDirectoryException there too. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Mikhail Filippov (mfilippov)
force-pushed
the
mf/fix-exceptions
branch
from
May 5, 2026 18:07
53161cc to
3e2742b
Compare
Ilia (k15tfu)
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tem#readdir
Files.walkFileTree throws java.nio.file.NoSuchFileException when the path is missing, but RemoteActionFileSystem.getDirectoryContents only catches java.io.FileNotFoundException — the NIO exception slipped past and broke validation of disk-cache-restored tree artifacts in BwoB mode (e.g. "error while validating output tree artifact ...: .../META-INF").
Translate NIO exceptions inside readdir to match the base JavaIoFileSystem.getDirectoryEntries contract:
Also guard the visitor: walkFileTree(maxDepth=1) calls visitFile on the start path when it isn't a directory, so detect that and surface a NotDirectoryException there too.