Repository navigation
ci: Claude review always reports, approves when sure, matches openpoker - #46
Merged
Merged
Conversation
Port the features the openpoker repo's review workflow has: - skip fork PRs, which cannot read the repo secrets - review every push without repeating settled points: read earlier inline comments and summaries first, and only re-raise a point the author answered if new commits reintroduce it. The code-review plugin otherwise stops once Claude has commented, so later pushes were never reviewed. Allows the read-only PR comments API call this needs. The PR number now comes from a job-level PR_NUMBER shared by both triggers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EaxBdAMckGCpk8mbWqaU13
- Every run ends with one summary comment: skipped (and why), no issues found, or N issues found, plus whether it approved. A follow-up step posts a "did not finish" comment if that summary is missing, so a crash or early stop is never silent. - Review small and trivial PRs too, instead of the plugin skipping them. - Approve only when nothing was found, no earlier finding is still open, Claude would be comfortable with it merging unread, and no sensitive path changed. If Claude approved an earlier push and cannot approve this one, it withdraws the approval with a change request. Never auto-approves changes to .github/ or install.sh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EaxBdAMckGCpk8mbWqaU13
|
Claude review: did not finish (step outcome: success). Nothing was reviewed or approved for this push. See the run log. |
Jish2
changed the title
Drafts and fork PRs never start the review job, so they got no word from it. A small pull_request_target workflow now comments when a PR opens or reopens as a draft, is converted to draft, or comes from a fork (with how to run the review by hand). It never checks out PR code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EaxBdAMckGCpk8mbWqaU13
|
Claude review: did not finish (step outcome: success). Nothing was reviewed or approved for this push. See the run log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the review workflow in line with
Jish2/openpoker(same file apart from the list of sensitive paths) and adds reporting and auto-approval.From openpoker
Always reports
claude-review-skip-notice.ymlcovers the PRs the review job never starts for. It comments when a PR opens or reopens as a draft or is converted to draft ("will run once marked ready"), and when a PR comes from a fork (with a link to run the review by hand). It usespull_request_targetso it can comment on fork PRs, and it never checks out PR code. Becausepull_request_targetruns from the base branch, it only takes effect after this merges.Auto-approve
gh pr review --approve) only when all of these hold:.github/orinstall.shchangedgh pr reviewon this PR, with--approveor--request-changes.This PR changes
.github/, so Claude won't approve it itself.🤖 Generated with Claude Code
https://claude.ai/code/session_01EaxBdAMckGCpk8mbWqaU13