Repository navigation
Fix sort requires moving requires above local require = require(...) - #1185
Open
mkantautas wants to merge 1 commit into
Open
mkantautas wants to merge 1 commit into
mkantautas wants to merge 1 commit into
Conversation
A require that rebinds `require` itself is no longer sortable, so it stays in place and splits its block. The requires after it, which call the new `require`, stay below it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With sort requires enabled,
local require = require(...)was sorted like any other require, by its name. In the example from #993 it moved below the six requires that call the newrequire, so those requires would run with the originalrequire.A require that rebinds
requireitself is now not sortable. It stays in place and splits its block, the same as any other local between requires. Requires before it are sorted above it, and requires after it are sorted below it.sort_requires.rsconst require = require(...) :: anywith requires on both sidescargo test(default, no default features, each dialect feature and all features),cargo fmt -- --checkandcargo clippy --all-features -- -D warningspass.This covers the case where the rebound variable is
requireitself. Requires that depend on a variable bound by another require are still sorted by name:local Util = require(script.Util)followed bylocal A = require(Util.A)still putsAfirst. That case needs the reference analysis suggested in the issue.Addresses the case reported in #993.