fix: attest only bound Docker host ports - #225
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45e9227145
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| evidence_refs: is_host_published_docker_port(port) | ||
| .then(|| { | ||
| docker_runtime_evidence( | ||
| snapshot, | ||
| &source, | ||
| &listener_id, | ||
| RuntimeEvidenceKind::DockerPortPublication, | ||
| evidence_provider_revision, | ||
| ) | ||
| }) | ||
| .into_iter() | ||
| .collect(), |
There was a problem hiding this comment.
When Docker reports a private-only port such as 80/tcp, this creates an Exposes edge with an empty evidenceRefs; however, the runtime inspector renders every empty list as “this relationship family is still migrating,” and the model/docs reserve that state for relationship families not yet migrated. Users inspecting a Docker-observed private port therefore receive an incorrect provenance explanation. Represent private-port exposure with an appropriate bounded evidence kind, or update the contract and UI to distinguish deliberately unattested edges from migration state.
AGENTS.md reference: AGENTS.md:L56-L57
Useful? React with 👍 / 👎.
45e9227 to
4701281
Compare
1 participant
Summary
Verification
No API, UI, schema, or contract artifact change: the wire model already carries bounded collector port strings and evidenceRefs permits empty lists for relationships without a direct attestation.