Skip to content

feat: validate Cron provenance at API boundary - #228

Open
Joncallim wants to merge 1 commit into
codex/68-cron-provenancefrom
codex/68-cron-provenance-api
Open

feat: validate Cron provenance at API boundary#228
Joncallim wants to merge 1 commit into
codex/68-cron-provenancefrom
codex/68-cron-provenance-api

Conversation

@Joncallim

Copy link
Copy Markdown
Owner

Summary

  • validate the closed V4 Cron schedule evidence shape before browser publication
  • require all seven daemon provider slots, including Cron, in API mock fallback and runtime maps
  • exercise the canonical V4 fixture, canonical/v1 pass-through, and neutral hostile rejection

Checks

  • npm run typecheck --workspace @dockermap/api
  • npm run test:api
  • npm run test:contracts
  • npm run check:contracts
  • npm run build --workspace @dockermap/api

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T14:37:56.924583Z 5a17d7b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a17d7b414

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

&& value.provider === "cron"
&& value.assertionKind === "declared"
&& value.providerSlot === "cron"
&& (value.freshness === "fresh" || value.freshness === "stale" || value.freshness === "timed_out");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Bind V4 evidence freshness to the Cron provider state

When a daemon returns internally inconsistent Cron data, this branch accepts the evidence freshness independently of the cron entry in providerStates; the added test at security.test.ts:1299-1307 even changes only the evidence to stale or timed_out while leaving the slot fresh. The real daemon derives the evidence freshness, providerRevision, and collectedAt from that exact slot in bind_cron_evidence, so a malformed daemon response can now publish impossible Cron provenance. Require these evidence fields to agree with the corresponding Cron provider state.

Useful? React with 👍 / 👎.

@Joncallim
Joncallim force-pushed the codex/68-cron-provenance-api branch from 5a17d7b to 8d069ab Compare September 2, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant