feat: surface bounded compose target advisory - #232
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4940af4 to
6fc32f6
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4940af4b3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return <Panel key={`${finding.ruleId}-${index}`} title={presentation.title} icon="alert" hint={presentation.hint}> | ||
| <div className="tag-wrap"><Tag tone={presentation.tone}>{presentation.severityLabel}</Tag><Tag tone="muted">{presentation.category}</Tag></div> | ||
| <p className="muted-copy">{presentation.recommendation}</p> | ||
| {presentation.inspectChanges && <Link className="ghost-link" to="/changes">Inspect recent changes <Icon name="arrow" size={14} /></Link>} |
There was a problem hiding this comment.
When this Compose card renders, the screen has already restricted it to the live/live context, but changeFeed returns CHANGE_HISTORY_CLAIM for every non-demo context, so /changes is guaranteed to show “Not collected” rather than any relevant history. The new “Inspect recent changes” action is therefore a dead end for every real Compose advisory; point it to current runtime/service evidence or omit it until live change collection is available.
Useful? React with 👍 / 👎.
1 participant
Summary
Checks
npm run typechecknpm run test -- --run src/lib/findingPresentation.test.ts src/screens/findings.test.tsxnpm run buildnpm run test:web(324 tests)