feat: validate daemon-state host-port findings - #234
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd4ebc64ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (const candidate of nodes) { | ||
| if (!candidate || typeof candidate !== "object") return false; | ||
| const node = candidate as Record<string, unknown>; | ||
| if (typeof node.id !== "string" || nodesById.has(node.id)) return false; |
There was a problem hiding this comment.
When generated IDs collide or publication normalization collapses two IDs, this check rejects the entire /daemon/runtime/map response. The daemon intentionally preserves such records as visible but non-routable and emits a collision diagnostic (crates/dockermap-daemon/src/publication.rs:38-50; likewise crates/dockermap-core/src/snapshot_runtime.rs:711-720), so the API now hides both the topology and its diagnostic. Track duplicate IDs as ambiguous and reject port evidence only when its listener target is ambiguous, rather than rejecting the whole map.
Useful? React with 👍 / 👎.
cbcaab8 to
997ccae
Compare
dd4ebc6 to
125c642
Compare
1 participant
Summary
Verification