fix: upgrade Express security dependency chain - #237
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
9a6f06d to
91363ad
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a6f06d9f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "ajv": "^8.20.0", | ||
| "cors": "^2.8.5", | ||
| "express": "^4.21.2", | ||
| "express": "^5.2.1", |
There was a problem hiding this comment.
Handle Express 5 listen errors
When startup encounters a bind failure such as EADDRINUSE or EACCES, Express 5 passes the error to the app.listen callback instead of throwing it. The callback in apps/api/src/index.ts ignores its argument and always logs that the API is listening, consuming the failure and allowing the process to exit successfully; because deploy/systemd/dockermap-api.service uses Restart=on-failure, the deployed API will remain down rather than restart. Update the Express type declarations to v5 and make the callback preserve a nonzero startup failure.
Useful? React with 👍 / 👎.
91363ad to
b3014db
Compare
Summary
qschain at 6.16.0app.routerand legacy_routerwithout changing request routes, auth, or runtime behaviorAudit evidence
npm audit --omit=devreported 3 moderate production findings:qs@6.15.2, propagated through Express 4/body-parser.npm audit --omit=dev --jsonreports 0 production vulnerabilities;npm ls qs --allresolves Express 5.2.1 → body-parser 2.3.0 → qs 6.16.0 with no invalid dependencies.npm cicontinues to report 3 high findings in development dependencies; they are outside--omit=devand are not changed by this production chain remediation.Verification