feat: flag mutual Compose dependencies - #240
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 134b356769
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let Some(reverse_edge) = runtime_map.edges.iter().find(|candidate| { | ||
| candidate.source == edge.target | ||
| && candidate.target == edge.source | ||
| && is_candidate_compose_dependency(candidate, &nodes) |
There was a problem hiding this comment.
Scope reciprocal dependencies to one Compose project
When separate Compose projects expose complementary unique service names—for example, project A's frontend declares backend while project B's backend declares frontend—the collector retains only the service name and ContainerAliases::resolve_dependency resolves it globally. These lines therefore accept the resulting cross-project edges as reciprocal because they share the same snapshot time and revision, emitting a mutual-dependency advisory even though neither project has a cycle. Preserve the Compose project identity and require both declarations to belong to the same project.
Useful? React with 👍 / 👎.
cbcaab8 to
997ccae
Compare
134b356 to
156c8a4
Compare
Summary
Verification
The API, web, and documentation companions will be stacked separately.