feat: validate mutual Compose findings at API boundary - #241
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a79e2c7ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return isCanonicalComposeEvidence(forward, finding.subjectRef) | ||
| && isCanonicalComposeEvidence(reverse, finding.targetRef) |
There was a problem hiding this comment.
When a malformed or compromised daemon returns two unrelated Compose observations, this accepts them as proof of a mutual dependency because it validates only each subjectRef; RuntimeEvidenceRef has no target field and its id is schema-checked only as a nonempty string. Production evidence IDs encode both source and target in docker_runtime_evidence (crates/dockermap-core/src/snapshot_runtime.rs), so the forward and reverse IDs must be validated against the expected A→B and B→A directions; otherwise /daemon/findings can publish an unsupported mutual-dependency conclusion.
Useful? React with 👍 / 👎.
134b356 to
156c8a4
Compare
0a79e2c to
4c97424
Compare
1 participant
Summary\n- validate the closed mutual Compose advisory contract before browser publication\n- add canonical fixture coverage for both API aliases\n- fail closed to the neutral 502 for malformed reciprocal evidence\n\n## Verification\n- npm run typecheck\n- npm run test:api\n- npm run test:contracts\n- npm run build\n- npm run generate:contracts