Skip to content

test: gate live Docker telemetry evidence - #244

Open
Joncallim wants to merge 1 commit into
codex/70-resource-telemetry-docsfrom
codex/70-resource-telemetry-live-evidence
Open

test: gate live Docker telemetry evidence#244
Joncallim wants to merge 1 commit into
codex/70-resource-telemetry-docsfrom
codex/70-resource-telemetry-live-evidence

Conversation

@Joncallim

Copy link
Copy Markdown
Owner

Summary

  • adds a separate exact dual-opt-in unfiltered telemetry fixture while preserving the label-scoped default
  • proves bearer protection, fixed finite gateway request shape, opaque closed response fields, current-model attachment, expiry bound, and Docker-to-mock reset
  • hardens fixture startup cleanup and removes ambient secrets from sudo daemon arguments

Current evidence

  • npm run typecheck passes
  • focused test without opt-in skips as intended
  • daemon-security.spec.ts passes with /daemon/resource-telemetry in the bearer matrix
  • focused dual-opt-in live run reached the owned gateway request (200) but timed out with the safe category collectionState=collecting, samples=0; fixture cleanup completed.

This PR does not claim live telemetry proof or update release documentation. It depends on a daemon telemetry completion fix before the new live test can pass.

Security review

Independent read-only review requested; final review pending.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T17:36:47.187441Z 8ea351a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Joncallim
Joncallim force-pushed the codex/70-resource-telemetry-live-evidence branch from 8ea351a to 74dcccf Compare September 2, 2026 17:32

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ea351a849

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

};

const telemetryPaths = ["/api/resource-telemetry", "/api/v1/resource-telemetry"] as const;
const token = "dockermap-unfiltered-telemetry-e2e-token";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use an unpredictable token for the unfiltered Docker test

When this dual-opt-in test runs on a shared Docker host, the source-visible bearer token can be reused by another local process to access the randomly bound daemon/API ports. Because this fixture deliberately removes the Docker label filter, those authenticated routes expose host-wide container inventory and potentially unrelated container logs rather than only owned fixture data. Generate a cryptographically random token for each run instead of committing the credential.

AGENTS.md reference: AGENTS.md:L21-L23

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant