test: gate live Docker telemetry evidence - #244
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
8ea351a to
74dcccf
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ea351a849
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }; | ||
|
|
||
| const telemetryPaths = ["/api/resource-telemetry", "/api/v1/resource-telemetry"] as const; | ||
| const token = "dockermap-unfiltered-telemetry-e2e-token"; |
There was a problem hiding this comment.
Use an unpredictable token for the unfiltered Docker test
When this dual-opt-in test runs on a shared Docker host, the source-visible bearer token can be reused by another local process to access the randomly bound daemon/API ports. Because this fixture deliberately removes the Docker label filter, those authenticated routes expose host-wide container inventory and potentially unrelated container logs rather than only owned fixture data. Generate a cryptographically random token for each run instead of committing the credential.
AGENTS.md reference: AGENTS.md:L21-L23
Useful? React with 👍 / 👎.
Summary
Current evidence
npm run typecheckpassesdaemon-security.spec.tspasses with/daemon/resource-telemetryin the bearer matrixcollectionState=collecting, samples=0; fixture cleanup completed.This PR does not claim live telemetry proof or update release documentation. It depends on a daemon telemetry completion fix before the new live test can pass.
Security review
Independent read-only review requested; final review pending.