test: verify finite Docker telemetry collection - #247
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 048e9d563a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expect(/^docker_container_[0-9a-f]{64}$/.test(sample.containerId)).toBe(true); | ||
| expect(sampleIds.has(sample.containerId)).toBe(false); | ||
| sampleIds.add(sample.containerId); |
There was a problem hiding this comment.
If telemetry regresses by retaining a stale or otherwise unrelated opaque container ID, these assertions still pass because they verify only ID syntax and uniqueness; currentModelRevision is likewise checked only for shape. The deleted /api/runtime/map comparison was the only live assertion that samples belong to the current model, which is part of the evidence required by docs/release/RELEASE_CHECKLIST.md:80-83. Restore a coherence check by polling telemetry and the runtime map until their model revisions match, then verify every sample ID exists in that map.
Useful? React with 👍 / 👎.
1 participant
Summary
Evidence
npm run typecheckpassed.DOCKERMAP_E2E_LIVE_DOCKER=1 DOCKERMAP_E2E_UNFILTERED_TELEMETRY=1 npx playwright test --config tests/e2e/playwright.config.ts resource-telemetry-live-docker.spec.tspassed. The owned fixture was cleaned up.npm run test:live-dockerwas attempted but remains red in the existing GUI live test attests/e2e/dockermap.spec.ts:521(Service Detail did not render after navigation). This PR does not claim that full suite is green.No merge or issue closure requested.