docs: lock Forge VNext general-agent architecture - #345
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32488f6bc4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## The Most Important Design Choice | ||
|
|
||
| Forge Core must not contain a permanent LLM parent agent. |
There was a problem hiding this comment.
Expand acronyms when first introduced
For readers entering through this standalone architecture, LLM is never expanded, and the document later introduces UI, CLI, API, MCP, DB, and ACP the same way; the new ADR and near-term roadmap repeat this problem. Expand each acronym on first use (for example, “large language model (LLM)”) or link to a glossary so the canonical VNext documents remain accessible to non-experts.
AGENTS.md reference: AGENTS.md:L168-L175
Useful? React with 👍 / 👎.
| This document is the **execution-order view** of the Forge roadmap. The current | ||
| VNext product direction is defined in | ||
| [`docs/forge-vnext-architecture.md`](forge-vnext-architecture.md) and | ||
| [ADR 0014](adr/0014-forge-vnext-general-agent-runtime.md). Epic | ||
| [#333](https://github.com/Joncallim/Forge/issues/333) is the umbrella programme. |
There was a problem hiding this comment.
Update the public roadmap entry points
Declaring VNext the current product direction leaves the public entry points contradictory: README.md:221-232 still presents the replaced #172→#184 sequence, while docs/roadmap.md:30-41 and docs/roadmap.md:451-455 still call Forge Workspace the next major direction even though this roadmap defers it at lines 330-338. Because the README links both documents as current roadmaps, readers receive mutually exclusive execution priorities; update or explicitly deprecate those stale sections in this change.
Useful? React with 👍 / 👎.
| - Software Engineering passes the same Phase 4 release gate as an installed | ||
| package. |
There was a problem hiding this comment.
Align phase numbers across the canonical roadmaps
This reference is ambiguous because docs/forge-vnext-architecture.md:845-847 maps the Software Engineering proof (#337) to Phase 3 and package extraction (#338) to Phase 4, while this roadmap inserts architecture freeze as step 0 and labels those same issues steps 4 and 5. Consequently, “the same Phase 4 release gate” can mean either the preceding #337 proof or the current #338 package phase depending on which canonical document is used; identify the gate by issue or adopt one numbering scheme.
Useful? React with 👍 / 👎.
Summary
Locks the reviewed Forge VNext product direction into the repository without claiming the future runtime is already implemented.
VNext reframes Forge as a local-first, budget-aware, deterministic-first runtime for installable AI Workforces, with Software Engineering as the first Workforce rather than the permanent product boundary.
Key decisions:
Iterative review
The architecture was revised through independent passes covering:
A final hostile specification pass also tightened concurrent budget reservations, unknown-cost provider policy, transitive package permissions, mandatory-gate ceilings, webhook/source authentication, typed model-output admission, and sensitive-artifact retention.
The documentation-governance pass removed conflicting roadmap authority and stale current-facing claims:
docs/roadmap.mdis now the canonical VNext product roadmap; the README/wiki distinguish today's coding-focused beta from the future VNext architecture;docs/workspace-roadmap.mdis explicitly deferred rather than the active implementation order.The review record uses the repository's scoped verdict language and records remaining implementation uncertainties instead of treating architecture confidence as proof.
Files
README.md— truthful current boundary plus accepted VNext direction and delivered trust foundations.docs/wiki.md— plain-English current-state/VNext overview aligned with the repository.docs/forge-vnext-architecture.md— full VNext architecture and invariants.docs/roadmap.md— canonical concise VNext product roadmap used by normal repo roadmap discovery.docs/near-term-roadmap.md— exact [EPIC] Forge VNext — budget-aware general agent runtime and installable Workforces #333 execution order and phase gates.docs/adr/0014-forge-vnext-general-agent-runtime.md— durable architecture decision/invariants.docs/architecture/forge-vnext-review-record.md— iterative adversarial review record.docs/adr/0007-forge-agent-workforce-model.md— scopes the existing coding-role taxonomy under VNext.docs/workspace-roadmap.md— preserves the Workspace design proposal but marks its old sequencing as superseded/deferred.GitHub programme
Umbrella: #333
Child phases: #334, #335, #336, #337, #338, #339, #340, #341, #342, #343, #344.
Epic #184 remains the canonical earned-autonomy/trust programme; this PR explicitly reuses #201/#185/#186 and requires remaining #187–#191 to align with VNext rather than create parallel orchestration truth.
Validation
Documentation/architecture-only change; no runtime code is changed.
196a4b376316a854c68f539b792a8b810ef160ed.Related: #333