Repository navigation
Clear ruff findings in the vendored library - #9
Merged
Merged
Conversation
Docstring wording and typing only, plus one bare except narrowed to Exception and an import moved above the function in const.py. No behaviour change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Reviewed-by: John Pettitt @jpettitt
Owner
|
Thanks — this has been bugging me since I turned Lint on. Read through every change and agree there's no behaviour change. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lint has been red on master since the workflow started installing: 28 findings, all in the vendored pysecspy and const.py, so every PR shows a failing check. This clears them: docstring wording,
OptionaltoX | None, anisinstancetuple, one unused import, one import moved above a function, and the bareexceptnarrowed toexcept Exception. No behaviour change; ruff is clean and the 18 tests pass.🤖 Generated with Claude Code and reviewed by @jpettitt