Fix SAM image cache invalidation (0.3.2) - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix stale SAM eye-mask embeddings when a different image reuses an object ID or the same image changes in place. The cache now validates object lifetime and exact pixels, and serializes embedding updates with prediction. Unchanged repeated eye queries still reuse their embedding.
Version 0.3.2 includes five portable regressions for cache invalidation, noncontiguous input, released references, failed refreshes and concurrent calls. All five fail the previous implementation and pass this candidate. The complete 26-test portable suite and exact source rebuild pass. The runtime diff is limited to the SAM adapter; existing UI and Metadata Killer assets are preserved. Real GPU mask-quality acceptance is separate from these cache-contract tests.