Fix HALO border continuity at rounded corners - #5
Open
soojy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the HALO border dash that gets cut at the top-left corner when the rounded perimeter is not an exact multiple of the dash pattern. Fit whole dash cycles to the perimeter while preserving the dash/gap ratio and animation speed.
Recalculate spacing only when dimensions change and reuse one two-element array per mounted surface. The draw-call count, canvas sizes, shadows, scheduler and visibility policy stay unchanged. Other frontend edits only refresh content-hashed imports and manifest entries.
Validation:
Video previews
Actual HALO renderer with enlarged corners. Click either animated preview to play the full MP4. Watch the synchronized side-by-side comparison.
Before
After