Repository navigation
typename: use nameof instead of reading UnionAll fields - #37
Merged
Merged
Conversation
typename probed isdefined(M, :name) and M.name.name, then M.body for a UnionAll. Julia 1.14 (JuliaLang/julia#63530) stores a UnionAll's binder name in a field called name, so the first branch returned the type variable's name instead of the type's. nameof gives the unqualified type name for both DataType and UnionAll on every supported Julia version. Assisted-by: Claude Code (Mythos 5.1)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #37 +/- ##
===========================================
- Coverage 100.00% 98.50% -1.50%
===========================================
Files 1 1
Lines 68 67 -1
===========================================
- Hits 68 66 -2
- Misses 0 1 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@Keno Great to have this fix to a hack. I'm surprised it lasted this long. Wish I'd known about |
This was referenced Oct 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typename probed isdefined(M, :name) and M.name.name, then M.body for a UnionAll. Julia 1.14 (JuliaLang/julia#63530) stores a UnionAll's binder name in a field called name, so the first branch returned the type variable's name instead of the type's. nameof gives the unqualified type name for both DataType and UnionAll on every supported Julia version.
Assisted-by: Claude Code (Mythos 5.1)