Repository navigation
Dump traits orientation and aggegration - #39
Merged
Merged
Conversation
This was referenced Nov 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the stated traits. These were originally defined to be overloaded by measures (metrics) defined in MLJBase but were rendered redundant by the migration of all measures to StatisticalMeasures.jl, which does not have StatisticalTraits as a dependency (and defines it's own traits
orientationandexternal_aggregation_mode). Since MLJBase and MLJ basically re-export all StatisticalMeasures.jl traits, this is causing some confusion noted at JuliaAI/MLJ.jl#1226 and this PR is a step towards resolving that issue.This change is to be tagged as breaking but doesn't actually break any registered dependant, as I have double checked locally. These dependants, listed below, will need to bump their StatisticalTraits.jl compats:
MLJBase, MLJModels, ScientficTypes, MLJModleInterface.