Skip to content

Dump traits orientation and aggegration - #39

Merged
ablaom merged 2 commits into
devfrom
dump-redundant-traits
Nov 22, 2026
Merged

ablaom merged 2 commits into
devfrom
dump-redundant-traits

Conversation

@ablaom

@ablaom ablaom commented Nov 22, 2026

Copy link
Copy Markdown
Member

This PR removes the stated traits. These were originally defined to be overloaded by measures (metrics) defined in MLJBase but were rendered redundant by the migration of all measures to StatisticalMeasures.jl, which does not have StatisticalTraits as a dependency (and defines it's own traits orientation and external_aggregation_mode). Since MLJBase and MLJ basically re-export all StatisticalMeasures.jl traits, this is causing some confusion noted at JuliaAI/MLJ.jl#1226 and this PR is a step towards resolving that issue.

This change is to be tagged as breaking but doesn't actually break any registered dependant, as I have double checked locally. These dependants, listed below, will need to bump their StatisticalTraits.jl compats:

MLJBase, MLJModels, ScientficTypes, MLJModleInterface.

@ablaom
ablaom merged commit f72bacf into dev Nov 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant