Skip to content

Declare whole interface as as public - #49

Merged
quinnj merged 2 commits into
JuliaDatabases:masterfrom
frankier:add-public
Aug 10, 2026
Merged

Declare whole interface as as public#49
quinnj merged 2 commits into
JuliaDatabases:masterfrom
frankier:add-public

Conversation

@frankier

@frankier frankier commented Feb 19, 2025

Copy link
Copy Markdown

This is already useful in practice with e.g. https://github.com/ericphanson/ExplicitImports.jl, which otherwise reports false positives for use of private implementation details.

Maintainer update:

  • rebased onto the current master
  • includes the documented interface types and parameter container aliases in the public API

Co-authored by Codex

@frankier

frankier commented Apr 1, 2025

Copy link
Copy Markdown
Author

@spaette Cheeky ping.

Hopefully this is an uncontroversial change/easy merge. Let me know if I can add any assurance.

@spaette

spaette commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

https://discourse.julialang.org/

Perhaps feedback could be solicited on the subject matter from the above online discussion venue for Julia.

@frankier

frankier commented Apr 3, 2025

Copy link
Copy Markdown
Author

Thanks for the information. It is quite a small change so I'll ping @quinnj first, but if there is some problem, I can take it to Discourse if they agree it would be useful.

@spaette

spaette commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

@oxinabox

Would you consider the subject matter of the PR having implications beyond the scope of a single Julia package?

@spaette

spaette commented May 6, 2025

Copy link
Copy Markdown
Contributor

@quinnj

Time permitting would you provide a second review?

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.25%. Comparing base (b1a1b00) to head (8509aa4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   82.25%   82.25%           
=======================================
  Files           1        1           
  Lines         124      124           
=======================================
  Hits          102      102           
  Misses         22       22           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quinnj

quinnj commented Aug 10, 2026

Copy link
Copy Markdown
Member

Thanks, Frankie. I rebased the PR and added the documented interface types to the public list. Julia 1.9 through nightly, docs, and coverage are green, so I am merging it.

[reviewed by quinnj, posted by codex]

@quinnj
quinnj merged commit 95da06b into JuliaDatabases:master Aug 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants