Declare whole interface as as public - #49
Conversation
|
@spaette Cheeky ping. Hopefully this is an uncontroversial change/easy merge. Let me know if I can add any assurance. |
|
Perhaps feedback could be solicited on the subject matter from the above online discussion venue for Julia. |
|
Thanks for the information. It is quite a small change so I'll ping @quinnj first, but if there is some problem, I can take it to Discourse if they agree it would be useful. |
|
Would you consider the subject matter of the PR having implications beyond the scope of a single Julia package? |
|
Time permitting would you provide a second review? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
=======================================
Coverage 82.25% 82.25%
=======================================
Files 1 1
Lines 124 124
=======================================
Hits 102 102
Misses 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks, Frankie. I rebased the PR and added the documented interface types to the public list. Julia 1.9 through nightly, docs, and coverage are green, so I am merging it. [reviewed by quinnj, posted by codex] |
This is already useful in practice with e.g. https://github.com/ericphanson/ExplicitImports.jl, which otherwise reports false positives for use of private implementation details.
Maintainer update:
masterCo-authored by Codex