Skip to content

Deprecate log2mexp? #141

Open
Open

Description

@devmotion

Follow-up to #140 (review):

That said, I am not sure that improving the precision of this function is the right way to tackle the problem. Apparently log2mexp is used in two places: the log(c)cdf of the Laplace function, and in tdistinvlogcdf in StatsFuns.

I am pretty sure that the first application at least should be handled as log1mexp(-z-loghalf), before rearranging the formula to use log2mexp. I am still looking at the second one.

Neither StatsFuns (JuliaStats/StatsFuns.jl#244) nor Distributions (JuliaStats/Distributions.jl#2115) uses LogExpFunctions.log2mexp anymore. StatsFuns and Distributions seemingly were the main (only?) users of log2mexp which raises the question: Is it worth keeping this function and the complexity required for numerically (reasonably) accurate evaluation in LogExpFunctions?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions