feat(wallet): add Freighter + LOBSTR wallet picker modal - #394
Open
chidii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #374 (draft — see caveats below, needs verification before ready for review)
Restricts the wallet connection kit to exactly Freighter + LOBSTR per
MVP scope (no Albedo/xBull/Hana). Uses @creit.tech/stellar-wallets-kit
v2's static API (init/createButton/getAddress/signTransaction/on),
verified against the package's current npm listing (v2.0.1) and official
docs at stellarwalletskit.dev.
LOBSTR uses its own dedicated module (not the generic WalletConnect
one), so no WalletConnect Cloud project ID is required.
The kit's own createButton() is used for both connecting (opens its
picker modal, showing only the two configured wallets) and disconnecting
(via its profile modal) — no custom disconnect logic was written, because
no standalone disconnect() method is documented anywhere in the kit's
docs, GitHub, or JSR listing. Routing through the kit's own UI was the
only way to satisfy the disconnect acceptance criterion without guessing
at an undocumented API for wallet-signing code.
Reconnect-on-reload relies on the kit's own internal session persistence
(documented behavior, not something this PR implements manually).
IMPORTANT — nothing in this PR has been run or clicked through by
anyone. Needs, before this leaves draft:
(@creit.tech/stellar-wallets-kit/sdk etc. — if this 404s on build,
try the hyphenated @creit-tech/stellar-wallets-kit form instead,
which is what the package's own README shows, inconsistently with
its registered npm scope name)
connect, LOBSTR connect (needs the LOBSTR mobile app for real QR
pairing), refresh-doesn't-reprompt, disconnect clears state,
cancel-leaves-null-no-toast
to confirm the signTransaction signature here still matches what
wallet-setup.ts expects