Repository navigation
fix(pds-combobox): shade drill-in group rows only for the keys - #879
Merged
Merged
Conversation
… pointer coming back
…and shade the row back for keys
…ck, and the flyout fallback
…and flyout fallback
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
10 of 12 tasks
pixelflips
reviewed
Oct 16, 2026
pixelflips
left a comment
Member
There was a problem hiding this comment.
Looks good overall. Two edge cases in the new drill-in shading are noted inline.
…whether the pointer hovers
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1b1fcf2. Configure here.
…o opening it is heard
…ng and announcement
pixelflips
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
At Email + CRM demo day, design flagged the
group-display="drill-in"panel. After you go back out of a group, the group row (for example "Email") stays shaded as if something inside it were picked, and it looks worse when that group holds the selection. Design's call is no shading for that in drill-in.flyoutkeeps highlighting the group that holds the selection, as designed.What changes in drill-in, including a
flyoutthat drills in for lack of room::hovershading while it's over a row, and nothing stays shaded once it moves on, or after a click-open or a pointer Back.@media (hover: hover). A touch browser keeps a tapped row hovered, so tapping Back would otherwise leave the row that takes its place shaded.flyout.Fixes DSS-363
Type of change
How Has This Been Tested?
group-display="drill-in"specs):pds-comboboxspec and e2e suites pass (268 specs, 49 e2e tests). Lint is unchanged frommain.Checklist:
Note
Low Risk
UI and accessibility behavior change scoped to grouped drill-in/flyout-fallback panels; flyout selection highlighting is unchanged and coverage is added in unit tests.
Overview
Fixes drill-in group row styling so shaded rows no longer look like a selected option (including after navigating back and when the current value lives in that group).
flyoutstill highlights the group that holds the selection.For drill-in (and flyout when it falls back to drill-in), group rows and the back row get persistent highlight classes only during keyboard navigation; the pointer uses
:hovervia apointerCanHoverflag frompointerType(so touch doesn’t leave a stuck hover after Back). The first ArrowUp/Down after a click-open or pointer highlight reveals that row (with a dedicatedaria-liveregion) instead of skipping past it.Docs in the Drill-In Groups section describe the behavior; bundle size limit for
pds-comboboxis bumped slightly; unit tests cover shading, reveal, touch vs mouse, and flyout fallback.Reviewed by Cursor Bugbot for commit e71db7d. Bugbot is set up for automated code reviews on this repo. Configure here.