Skip to content

refactor: isolate receipt review and preserve money input - #30

Merged
Kamitoad merged 1 commit into
mainfrom
codex/receipt-review-maintenance
Oct 8, 2026
Merged

Kamitoad merged 1 commit into
mainfrom
codex/receipt-review-maintenance

Conversation

@Kamitoad

@Kamitoad Kamitoad commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Preserve the existing local money-field fix for issue Preserve money-field input while typing #23, including partial input, blur formatting, explicit invalid-state feedback, and save gating.
  • Correct Android backup documentation and distinguish implemented features from pending physical-device acceptance and unsupported webserver migration.
  • Add 17 rendered React interaction tests and 20 shared adapter characterization cases.
  • Extract receipt review, item cards, field controls, status indicators, and icons without redesigning the German mobile-first UI.
  • Share equivalent validation rules and UI-facing API contracts while keeping web/Android persistence and backup formats separate.

Verification

  • pnpm check: 126 tests in 15 files passed, with TypeScript checks.
  • pnpm build: passed; existing non-blocking Zod/Rollup annotation warnings remain.
  • git diff --check: passed.
  • Targeted Opera smoke checks at 412x915 and 360x800: no horizontal overflow, money correction/invalid-input gating, synthetic receipt create/save/edit with no duplicate.
  • The user additionally confirmed the development UI worked in their phone browser over Wi-Fi.
  • No physical Android app acceptance, virtual-keyboard/touch regression pass, offline persistence, or native backup/update acceptance was performed.
  • No database migrations or backup-format changes.

Distribution

This source PR does not distribute an APK. After merge, explicitly request the durable-signed Android installable update workflow on main, then complete the real-device checklist before relying on native storage or backups.

Refs #23. Device-specific acceptance remains separate; do not infer acceptance from simulated native tests or web-browser feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant