Add zstd dictionary compression strategy - #456
Draft
hendrikmuhs wants to merge 6 commits into
Draft
hendrikmuhs wants to merge 6 commits into
hendrikmuhs wants to merge 6 commits into
Conversation
Add ZstdDictCompressionStrategy that uses pre-trained zstd dictionaries for improved compression of small values. The dictionary is passed at construction time and used for both compression and decompression via ZSTD_CDict/ZSTD_DDict. Co-Authored-By: Claude Code <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-Authored-By: Claude Code <noreply@anthropic.com>
- Add override to destructor - Add deleted move constructor/assignment operator - Use explicit nullptr comparisons instead of implicit bool conversion - Use explicit != 0u for ZSTD_isError checks - Add braces around single-line if bodies - Use operator[] instead of data()[0] - Make result variable const - Add NOLINTNEXTLINE for unavoidable pointer arithmetic - Add missing direct includes for cstddef, cstdint, compression_algorithm.h Co-Authored-By: Claude Code <noreply@anthropic.com>
- Use uppercase literal suffix 0U instead of 0u - Add [[nodiscard]] to name() and GetFileVersionMin() - Remove unused include from compression_selector.h - Add samples.reserve(200) before loops in tests - Make dict_size, plain_size, strategy const where possible Co-Authored-By: Claude Code <noreply@anthropic.com>
- Replace ZSTD_DEFAULT_CLEVEL macro with constexpr kZstdDefaultCompressionLevel - Use C++17 concatenated namespace keyvi::compression Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ZstdDictCompressionStrategy that uses pre-trained zstd dictionaries for improved compression of small values. The dictionary is passed at construction time and used for both compression and decompression via ZSTD_CDict/ZSTD_DDict.