Repository navigation
Desktop: Personas and the chat header's picker mark who the chat is on the same way (#348) - #350
Merged
Merged
Conversation
…348) Red first: Settings → Personas marks the chosen card (aria-current, "In the chat", "Use the assistant") and has an Assistant row that takes the mark when no persona is chosen; the header picker marks the same row, says the choice is saved to the account and leads to Personas; a persona without a picture has the person icon. The persona-optional spec now expects the chip to move to the Assistant row. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014L9pxjp1MTSJe5DZG9A9sv
… the same way (#348) Section 2 of the Claude Design mockup "Kurisu - Voice Mode v1": - One "In the chat" chip (InTheChatChip) and blue outline on the chosen persona's card, its row in the header picker, and a new Assistant row above the cards, which otherwise is a dashed row that puts the chat on the assistant. - The chosen card offers "Use the assistant", the others "Talk to". - The picker says the choice is saved to the account and ends with "Manage personas". - A persona without a picture shows the person icon; the assistant keeps its robot. - The personas grid sizes its columns to the pane. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014L9pxjp1MTSJe5DZG9A9sv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #348
Section 2 of the Claude Design mockup "Kurisu - Voice Mode v1": who the chat is on is marked the same way wherever it is chosen.
What changes
InTheChatChip,selectionColors): the "In the chat" chip, a blue outline (drawn inset, so choosing never shifts the grid) and a tinted row.aria-currenton the chosen one.auto-fill, 240 px minimum), not the window width, so the card actions do not wrap.Tests
Written first (
656d0f5), red against the old code:inTheChat.spec.ts(3): the card and the Assistant row carry the mark and move it; the picker marks the same row, says it is saved to the account, and leads to Personas; the person icon versus the assistant's.personaOptional.spec.ts: after "Use the assistant" the chip is no longer gone. It moves to the Assistant row, so the assertion says that.Locally: the ui suite 156;
inTheChat,personaOptional,personaExport14/14 in Electron. Screenshots in light and dark checked against 2a.docs/assets/04-settings-personas.pngis regenerated with the documented capture.Not done
getPlaywrightAutostart. That screenshot is left as it was, so it isn't touched here.🤖 Generated with Claude Code
https://claude.ai/code/session_014L9pxjp1MTSJe5DZG9A9sv