feat(GLTFImporter): add extensions & animations support - #3513
Open
daker wants to merge 12 commits into
Open
Conversation
daker
force-pushed
the
gltf-anim-ext
branch
6 times, most recently
from
May 25, 2026 16:52
7e0d2b0 to
2956595
Compare
Collaborator
Author
|
@sankhesh mind also looking at this PR when you have time ? |
Collaborator
Author
|
@sankhesh any chance to get a review ? |
daker
force-pushed
the
gltf-anim-ext
branch
2 times, most recently
from
August 17, 2026 18:42
ac2af82 to
5dcc09d
Compare
Collaborator
Author
|
@sankhesh can i have a review please ? |
finetjul
reviewed
Aug 18, 2026
- traverse armature bones parents-first so out of order glTF joints compute correct world matrices - insert placeholder bones for null joints to keep bone indices aligned with JOINTS_0 and the inverse bind matrices accessor - expose animation clips from all skins instead of only the first - dequantize normalized integer accessors (colors, weights, quantized animation outputs) per spec - honor textureInfo.texCoord as fallback with KHR_texture_transform and stop hijacking the mesh active tcoords for emissive UVs - default KHR_materials_ior to 1.5 per spec (also for the reset path) - position punctual lights with the node world matrix and deduplicate light map keys so unnamed lights are not dropped - decompose node.matrix into rest TRS for node transform animations
…root skins - drop the intensity / PI conversion: the PBR light loop already follows the Khronos reference (radiance = color * intensity, 1/PI lives in the lambertian BRDF), so the division dimmed glTF lights by PI - honor an explicit light intensity of 0 - compute the skeleton root transform per root joint and warn when root joints require different ancestor transforms
daker
force-pushed
the
gltf-anim-ext
branch
3 times, most recently
from
August 22, 2026 14:18
4e00f04 to
0376461
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #3501
GLTF Extensions:
New animation framework in core/data model
PBR debugging
Results
Enregistrement.2026-05-20.012513.mp4
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting