Repository navigation
Treat bundled Boost headers as system includes - #3
Merged
Merged
Conversation
Knogle
added a commit
that referenced
this pull request
Mar 13, 2026
Treat bundled Boost headers as system includes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
-Werror=nonnullerrors which breaks the build, so warnings from bundled Boost headers must be suppressed without touching global compiler flags.nonnullas an error is removed in favor of marking the bundled Boost headers as system includes so the compiler will not treat Boost warnings as project errors.Description
include_directories(${PROJECT_SOURCE_DIR}/lib/boost)withinclude_directories(SYSTEM ${PROJECT_SOURCE_DIR}/lib/boost)to mark the bundled Boost headers as system includes.-Wno-error=nonnullcompile option so no ad-hoc warning-suppression flags are kept in the build system.Testing
Codex Task