Repository navigation
feat(dev): scope Compose services to development sessions - #62
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local development previously left the application and backup sidecar running between tasks, with restart policies that could revive them after a Docker restart. Local Compose now runs as an explicit foreground session and tears down after verification while preserving the database, credentials, and backups.
make devrebuilds, checks readiness, and owns the foreground session; INT, TERM, HUP, or service exit triggers cleanup.make dev-checkrebuilds, probes, and exits;make dev-stoprecovers abandoned detached stacks. The defaultmaketarget remains the unit checks.N2API_DEV_METRICS=1 make devand is accepted by recovery checks.deploy_n2api-postgres.Validation passed:
make test-dev-artifactsmake test-opsdev/ci/test-dev-artifacts.shanddev/ci/test-dev-session.shwith temporary fixtures on NFSbash -n dev/development/run.sh dev/ci/test-dev-session.sh dev/lib/test-resources.shdev/ci/verify-pinned-dependencies.shdocker compose -f deploy/compose.yaml -f deploy/compose.metrics.yaml config --quietmake -n;git diff origin/main --checkmake dev-checkandN2API_DEV_METRICS=1 ... make dev-check: no-cache build, healthy services,/livez,/readyz,/version, and bootstrap-page probes, followed by complete teardown and zero build cachemake dev-stopafter teardown, proving idempotencyThe original database system identifier and existing backup SHA256 checksums were preserved. No development containers or networks remain. Small ownership/permission-sensitive test fixtures used private local
/tmpdirectories because the mounted NFS root-squashes UID and inherits setgid bits; those fixtures were removed, with logs kept remotely.Local Codex review:
codex review --base origin/mainpassed on33348a74142b1d7b2d4cd19acb7ecb63bca0da13with no actionable findings. The initial review findings about forced-exit lock recovery and the metrics override were reproduced, fixed, and verified before this final review.No production change, release, or real-provider acceptance was performed. SIGKILL/host crashes require the documented
make dev-stoprecovery.