Repository navigation
refactor!: keep API-key upstreams only - #64
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
N2API now accepts API-key upstreams only. Remove OAuth authorization, callback,
refresh, Codex catalog and gateway transformations, fingerprint management and
bindings, synthetic Codex identity headers, and uTLS. Preserve normal API
routing, proxy transports, streaming, model sync, and response affinity.
Historical OAuth accounts and fingerprint data remain in PostgreSQL and
redacted configuration exports. They cannot be selected, edited, deleted,
probed, or exposed as active models. Existing installations must replace their
OAuth routing-pool memberships with API-key upstreams. No production operation
or credential deletion is included.
Validation
cd backend && go test ./...passed.cd backend && go mod tidy -diffandgo vet ./...passed.GOFLAGS=-buildvcs=falsefor the sandboxed NFS worktree).cd frontend && bun test: 216 passed.cd frontend && bun run --bun check: zero errors and warnings.N2API_FRONTEND_BUILD_DIR="$TMPDIR/frontend-dist" bun node_modules/vite/bin/vite.js buildpassed.go test -count=1 -run 'TestProviderRepositoryListExposedModelsForRoutingPools|TestListExposedModelsForRoutingPoolFiltersUnschedulableAccounts|TestAllMigrationsRoundTrip|TestOpsAccountHealthExcludesRetiredOAuthAccounts' ./internal/storepassed.make test-e2epassed against the isolated PostgreSQL and mock upstream stack.make dev-check: no-cache rebuild, live/readiness/version/page probes, and teardown passed;deploy_n2api-postgrespreserved.Real-provider and production acceptance were not run.
Local review
codex review --base origin/maincompleted on the published diff with noexplicit actionable regression findings. Earlier findings about retired OAuth
callback fallback, test fixtures, and current account-health statistics were
fixed and verified before this final review. The task worktree is clean at
35ae1ad09290957bc93290df8edf9ab373af4244.