Repository navigation
fix(ci): support Docker manifest IDs in image publication - #66
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Release run 42580798250 built and smoke-tested both platform images, then rejected publication because Docker's local image ID matched the pushed manifest digest rather than its config digest.
Treat the exported identity as an image ID and accept an exact match against either the remote config or manifest digest. Preserve archive checksums, the export/load identity check, immutable platform tags, and all other release gates.
The existing extracted-workflow tests now cover config IDs, manifest IDs, unrelated IDs, and malformed manifest digests. The manifest-ID case reproduced the original failure before the fix.
Verification
bash -n dev/ci/test-security-policy.shpassed.bash dev/ci/test-security-policy.shpassed.bash dev/ci/test-dev-artifacts.shpassed.git diff --checkpassed.make dev-checkpassed: no-cache rebuild, recreation, health/page probes, and teardown; the existing PostgreSQL volume was preserved.codex review --base origin/main: passed with no actionable findings for commit 112495e.This fixes release publication only. Stable release tags and latest were not changed by the failed attempt. Production deployment is outside this task.