Skip to content

Polish UI hierarchy and cloud workspace feedback - #7

Merged
KnowSky404 merged 1 commit into
mainfrom
feat/ui-hierarchy-polish
Oct 27, 2026
Merged

KnowSky404 merged 1 commit into
mainfrom
feat/ui-hierarchy-polish

Conversation

@KnowSky404

@KnowSky404 KnowSky404 commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Problem and resulting behavior

SubMan's simplified shell made its brand, navigation, icon controls, and cloud status difficult to distinguish. This change restores a clear Primer-style hierarchy, accessible icon tooltips, visible cloud status, and discoverable mobile navigation. It improves list readability and filtered empty states, surfaces recent resources and cloud-confirmed publication metadata on the overview, and groups advanced aggregation options with clearer publish prerequisites. Chinese labels and both Wiki guides are updated.

Task and verification evidence

  • Worktree / branch: /root/Clouds/SubMan-ui-polish / feat/ui-hierarchy-polish.
  • Base SHA: e015b6f650abfe8c3aa89cbf9c741495f783e465; tested head SHA: 1c1eae68888c61adeec1aecee8c97819e52ad100.
  • Local checks: Bun 1.3.14; 679 unit tests; docs check (37 pages); Svelte/Worker type checks; lint; production build; eight local Cloudflare integration tests; sing-box 1.14 validation of 15 generated outbounds; Worker deployment bundle dry run.
  • Browser checks: the 56-case Playwright suite passed with one worker using a local Worker and mock GitHub data. Following the final tooltip-listener cleanup and test-only fixture adjustments, eight UI cases, two settings cases, and five migration cases were rerun successfully. PR CI will run the full browser suite on the pushed head.
  • Screenshots: desktop and mobile previews were captured locally in /tmp/subman-ui-polish-qa; they are not attached to this PR. All six routes were inspected at desktop size and at 390px/320px, in light and dark themes and English/Chinese. Keyboard and hover tooltips, menu navigation, filter reset, console health, and overflow were checked.
  • Limitations: the full browser suite was not rerun after the final tooltip-listener and test-only adjustments. Real GitHub Gists and production were not accessed.
  • CI results for this head: CI verify succeeded, including the full browser suite, on 1c1eae68888c61adeec1aecee8c97819e52ad100.

Review gate

  • Codex Code Review completed for the current head; author and SHA verified.
  • Security Review and other required reviews completed when enabled; actual repository configuration checked.
  • Review SHA, completion times, and evidence links recorded below.
  • Valid blocking findings resolved; false positives explained with evidence.
  • Required CI checks passed for the current head; new commits reviewed again.

Review evidence: Codex Review Summary, author chatgpt-codex-connector[bot], head 1c1eae68888c61adeec1aecee8c97819e52ad100. Code Review completed 2026-10-27 08:28:31 UTC and Security Review completed 2026-10-27 08:29:32 UTC; both reported no findings and no unresolved findings. The PR has no inline review threads or submitted review findings. Repository inspection found no branch protection or applicable rulesets; Security Review was enabled and completed, despite its merge gate being disabled.

Merge and completion

  • Merge authorization / PR: user-authorized rebase merge, Polish UI hierarchy and cloud workspace feedback #7; original head 1c1eae68888c61adeec1aecee8c97819e52ad100, merge SHA 4e01863dd5f9f378ec035099d26049ae86c2f6ca, merged 2026-10-27 08:31:37 UTC.
  • Main integration and sync: merge SHA verified in origin/main; git range-diff showed equivalent patches, and the original and rebased trees were identical. The clean original main checkout was fast-forwarded to the merge SHA.
  • Cleanup: the task worktree and local branch were removed; the remote branch was conditionally deleted with a lease pinned to the verified PR head. Local screenshots, logs, and generated Worker validation artifacts remain under /tmp/subman-ui-polish-qa on the development machine. No production deployment was performed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T08:28:31.672507Z 1c1eae6 PR opened
🔒 Security Review ✅ Completed 2026-10-27T08:29:32.542392Z 1c1eae6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@KnowSky404
KnowSky404 merged commit 4e01863 into main Oct 27, 2026
1 check passed
@KnowSky404
KnowSky404 deleted the feat/ui-hierarchy-polish branch October 27, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant