Skip to content

feat(ui): refine Primer surfaces and interaction feedback - #8

Merged
KnowSky404 merged 1 commit into
mainfrom
feat/primer-interaction-system
Oct 28, 2026
Merged

KnowSky404 merged 1 commit into
mainfrom
feat/primer-interaction-system

Conversation

@KnowSky404

@KnowSky404 KnowSky404 commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Problem and resulting behavior

The six application routes had inconsistent hierarchy, duplicated working controls, and limited interaction feedback. This change applies the approved Primer direction across the shell and pages, adds shared motion, copy acknowledgement and asynchronous action feedback, and makes mobile editors accessible bottom sheets.

Cloud confirmation remains authoritative: queued, retrying, blocked or uncertain outcomes keep drafts; only a confirmed remote commit finalizes them. Automatic theme mode now applies the resolved palette before first paint and when the OS preference changes. Public APIs, Workspace storage/schema, mutation semantics and security headers are unchanged.

Task and verification evidence

  • Worktree / branch: /root/Clouds/SubMan-premium-ui / feat/primer-interaction-system.
  • Base SHA: 4e01863dd5f9f378ec035099d26049ae86c2f6ca.
  • Tested head SHA: c5cacfce820b016ba0d9d99b36aa4f4639414c01.
  • Local checks with Bun 1.3.14: 678 unit tests, 8 Worker integration tests, 63 Chromium E2E tests, and 96 responsive/theme/language views passed. Type/Worker-type checks, lint, build, bilingual documentation checks, sing-box 1.14.0 validation (15 outbounds) and Wrangler deployment dry run passed.
  • CI for this head: verify succeeded, completed 2026-10-28 06:13:09 UTC for c5cacfce820b016ba0d9d99b36aa4f4639414c01.
  • UI evidence: design comparison and execution record, with approved source artwork under docs/assets/ui/2026-10-28/. Actual desktop/mobile, edit and pending screenshots are retained locally under /tmp/subman-premium-ui-qa/; screenshots have not been uploaded as PR attachments.
  • Limits: local Worker and synthetic cloud responses; Chromium only. Safari/Firefox, physical mobile keyboards and real-provider writes were not exercised. No new runtime dependency. No production deployment.

Review gate

  • Codex Code Review completed for the current head; author and SHA verified.
  • Security Review and other required reviews completed when enabled; actual repository configuration checked.
  • Review SHA, completion times, and evidence links recorded below.
  • Valid blocking findings resolved; false positives explained with evidence.
  • Required CI checks passed for the current head; new commits reviewed again.

Review evidence for c5cacfce820b016ba0d9d99b36aa4f4639414c01:

  • Actual author: chatgpt-codex-connector[bot].
  • Codex Review Summary: each review item and embedded full commit SHA checked separately.
  • Code Review completed 2026-10-28 06:12:08.216683 UTC; no findings or unresolved findings.
  • Security Review completed 2026-10-28 06:13:56.839534 UTC; no findings or unresolved findings. Security review is enabled for this PR; its P0 merge gate is disabled, but project policy still required completion.
  • Associated submitted reviews and inline review threads inspected: both empty, consistent with no findings.
  • Repository inspection: rebase merges enabled, no main branch protection/rulesets, no other outstanding requested reviewers/checks. CI succeeded above. Main and PR base remain 4e01863dd5f9f378ec035099d26049ae86c2f6ca.

Merge and completion

  • User authorized push, PR creation, rebase merge and task branch cleanup.
  • PR: feat(ui): refine Primer surfaces and interaction feedback #8. Rebase merged at 2026-10-28 06:16:00 UTC.
  • Original reviewed head: c5cacfce820b016ba0d9d99b36aa4f4639414c01.
  • Merge SHA: cdaf7487b85727915ecf2afc219cbc40b5fcbd64.
  • Main integration: merge SHA is contained in origin/main; git range-diff reports the original and rebased commits equivalent. The entire reviewed and merged trees match (783c9bee8fe6a61048984e2b1eb0a54c9aaee02c); there was no integration content change.
  • Original checkout /root/Clouds/SubMan fast-forwarded to the merge SHA and is clean, matching origin/main.
  • Post-merge main CI also passed for cdaf7487b85727915ecf2afc219cbc40b5fcbd64, completed 2026-10-28 06:18:51 UTC.
  • Cleanup complete: removed /root/Clouds/SubMan-premium-ui without force; deleted local and remote feat/primer-interaction-system. Remote deletion used an explicit lease pinned to the reviewed original head, and absence was verified.
  • Validation evidence remains outside the removed worktree in /tmp/subman-premium-ui-qa, /tmp/subman-premium-*.log, and /tmp/subman-pr8-delivery. Ignored temporary Worker test state was preserved; no private configuration was present. Temporary services are stopped.
  • No remaining review, integration, sync or cleanup blockers.
  • Production deployment and Wiki publication are outside this request.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T06:12:08.216683Z c5cacfc PR opened
🔒 Security Review ✅ Completed 2026-10-28T06:13:56.839534Z c5cacfc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@KnowSky404
KnowSky404 merged commit cdaf748 into main Oct 28, 2026
1 check passed
@KnowSky404
KnowSky404 deleted the feat/primer-interaction-system branch October 28, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant