Repository navigation
feat(updater): support custom GitHub release sources - #294
Open
WilliamWang1721 wants to merge 52 commits into
Open
WilliamWang1721 wants to merge 52 commits into
WilliamWang1721 wants to merge 52 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved findings affect stale update state, reset behavior, release-link validation, and localized validation errors.
Review effort: Lite
Findings: 3
Open (3)
What changed in this PR
Adds a persisted custom GitHub Releases source while reusing the existing update and download pipeline.
Changes:
- Adds
update_release_urlwith reset support and Settings UI. - Implements GitHub release-source parsing and asset validation.
- Updates checks, downloads, release links, and localization.
| File | Summary |
|---|---|
nebula_settings/src/reset.rs |
Registers the setting for reset; reset does not invalidate stale checks or cancel downloads (moderate, 4 votes). |
nebula_settings/src/lib.rs |
Adds persistence, defaults, and tests. |
nebula_app/src/update_download.rs |
Applies source-aware download validation. |
nebula_app/src/update_check/source.rs |
Parses sources and validates assets; UI errors are hardcoded in Chinese (nit, 1 vote). |
nebula_app/src/update_check.rs |
Uses configured release sources. |
nebula_app/src/gpui_shell/workspace/update_dialog.rs |
Opens configured release pages. |
nebula_app/src/gpui_shell/settings_pane/initialization.rs |
Initializes the source input. |
nebula_app/src/gpui_shell/settings_pane/about.rs |
Adds source editing and links; background results can become stale after source changes (moderate, 4 votes), and links bypass source parsing (moderate, 2 votes). |
nebula_app/src/gpui_shell/settings_pane.rs |
Stores and localizes source input state. |
nebula_app/i18n/zh-CN.json |
Adds Simplified Chinese strings. |
nebula_app/i18n/en-US.json |
Adds English strings. |
architecture/notes/nebula_app/update_check/2026-09-25-custom-release-source.md |
Documents the design decision. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
# Conflicts: # nebula_app/src/gpui_shell/workspace/windowing.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Add one optional custom GitHub Releases source to Settings → Application while keeping the existing updater pipeline unchanged.
Kuddev/pebrelupdater..../releasesor.../releases/latestchecks that repository's latest release..../releases/tag/<tag>checks that exact release, so fork builds and beta/preview releases can be selected.Design
This intentionally changes only the release-source boundary.
github.com/<owner>/<repo>/releases...URLs.Scope
The implementation is intentionally small:
update_release_urlsetting;The existing
fallback.rsandassets.rsremain identical to upstreammain.Validation
4e47c5ca79a7627393daf1eb333b58a6a490fcdc(base360613aa6eedfa4e441d658d98db502e8a81442b). Post-sync snapshot:architecture-contractsandlintpending;pr-sizepassed. Native Tests jobs were not reported. See live PR checks for current state.AI assistance for this review and follow-up: GPT-6 Luna (max reasoning effort). Earlier implementation model metadata is unavailable in this continuation.